Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vita: ensure the displayed time is in the local timezone #8321

Closed
wants to merge 1 commit into from
Closed

Vita: ensure the displayed time is in the local timezone #8321

wants to merge 1 commit into from

Conversation

althonos
Copy link

Guidelines

  1. Rebase before opening a pull request ✅
  2. If you are sending several unrelated fixes or features, use a branch and a separate pull request for each ✅
  3. If possible try squashing everything in a single commit. This is particularly beneficial in the case of feature merges since it allows easy bisecting when a problem arises ✅

Description

This makes the time displayed in the main menu the local time instead of the UTC time, using SDK functions because newlib's localtime is not aware of timezones.

The patch works (tested on a UTC+1 PS Vita) but my main concern is to know whether the code is in the right place or not.

Related Issues

Reviewers

I don't know who's the PS Vita expert dev in here 😅

@gouchi
Copy link
Member

gouchi commented Feb 21, 2019

ping @frangarcj

@althonos
Copy link
Author

I also PR'ed an upstream patch: vitasdk/newlib#41.

@althonos
Copy link
Author

Upstream was fixed, closing.

@althonos althonos closed this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Vita) RetroArch does not recognize the time zone from the system
2 participants
@althonos @gouchi